Skip to content

fix(lambda-event-sources): dynamo batch size cannot be a CfnParameter#16540

Merged
mergify[bot] merged 4 commits intoaws:masterfrom
i05nagai:support-token
Oct 29, 2021
Merged

fix(lambda-event-sources): dynamo batch size cannot be a CfnParameter#16540
mergify[bot] merged 4 commits intoaws:masterfrom
i05nagai:support-token

Conversation

@i05nagai
Copy link
Copy Markdown
Contributor

fixes #16221


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 18, 2021

Copy link
Copy Markdown

@jaresuth jaresuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 This looks good to me. I was working on the same change :).

Copy link
Copy Markdown
Contributor

@LukvonStrom LukvonStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@peterwoodworth peterwoodworth changed the title fix(aws-lambda-event-sources): accept token for dynamodb batch size fix(aws-lambda-event-sources): accept token for dynamodb batch size Oct 21, 2021
Copy link
Copy Markdown

@mnanchev mnanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me :)

@nija-at nija-at changed the title fix(aws-lambda-event-sources): accept token for dynamodb batch size fix(lambda-event-sources): dynamo batch size cannot be a CfnParameter Oct 28, 2021
nija-at
nija-at previously approved these changes Oct 28, 2021
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@i05nagai
Copy link
Copy Markdown
Contributor Author

i05nagai commented Oct 29, 2021

@nija-at Thank you for the review! The build failed because of a 500 error from npmjs servers. Is it possible to re-run the build?

@mergify mergify bot dismissed nija-at’s stale review October 29, 2021 08:34

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 223b3dc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 56974ac into aws:master Oct 29, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…aws#16540)

fixes aws#16221 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-lambda-event-sources: DynamoEventSource batchSize not assignable via CfnParameter

6 participants