chore(individual-pkg-gen): remove L1s from alpha modules, and support…#16482
Closed
madeline-k wants to merge 3 commits intoaws:masterfrom
Closed
chore(individual-pkg-gen): remove L1s from alpha modules, and support…#16482madeline-k wants to merge 3 commits intoaws:masterfrom
madeline-k wants to merge 3 commits intoaws:masterfrom
Conversation
… rewriting Cfn imports that are combined in one line with other imports
|
|
Contributor
Author
|
Alternative option: #16481 |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… rewriting Cfn imports that are combined in one line with other imports.
This change does some extra hacky source text manipulation to be able to rewrite an import like this:
into this:
I am definitely open to suggestions on ways to make this cleaner. I am skeptical that this won't introduce some unexpected behavior with an import format not covered by the tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license