chore(individual-pkg-gen): remove L1s from alpha modules#16481
chore(individual-pkg-gen): remove L1s from alpha modules#16481mergify[bot] merged 37 commits intoaws:masterfrom
Conversation
|
|
|
See #16354 for previous discussion/context. |
…nstructs from other alpha modules. Cfn imports need to come from aws-cdk-lib, while L2 construct imports need to come from the alpha modules.
...nt-plugin-cdk/test/rules/fixtures/invalid-cfn-imports/cfn-import-mixed-with-other-imports.ts
Show resolved
Hide resolved
…oded magic number
…Identifier that starts with Cfn, not xxx.Cfn
| return newPath; | ||
| } | ||
|
|
||
| async function lintAndGetErrorCountAndMessage(file: string) { |
There was a problem hiding this comment.
very long name. Why not just lint()?
| @@ -0,0 +1 @@ | |||
| To allow rewriting imports when generating v2 experimental packages, `CfnDeliveryStream` must be imported by name and separate from non-L1 imports, since it is being imported from an experimental package: @aws-cdk/aws-kinesisfirehose No newline at end of file | |||
There was a problem hiding this comment.
Why support only one error message in an .error.txt file? We should support writing tests that produce multiple error messages.
And it should be order insensitive.
There was a problem hiding this comment.
I implemented this to be one line per error message in the error.txt file, let me know if you have thoughts to make that format better! csv, maybe?
There was a problem hiding this comment.
How about one error message per line?
njlynch
left a comment
There was a problem hiding this comment.
Looks good! Nice job slogging through this; it ended up being more complex than we original guestimated! :)
requested changes have been addressed.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The PR contains the following changes:
1. Skip copying the generated L1 files into the alpha modules
2. Re-write imports in the alpha modules that reference L1s to reference aws-cdk-lib/aws-
These imports come in the following formats: `./<service>.generated`, `../<service>.generated`, `../lib/<service>.generated`. All of these formats get converted to aws-cdk-lib/aws-<service>
3. Don't export generated L1s in the index.ts files of the alpha modules.
Closes aws#15587
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The PR contains the following changes:
These imports come in the following formats:
./<service>.generated,../<service>.generated,../lib/<service>.generated. All of these formats get converted to aws-cdk-lib/aws-Closes #15587
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license