Skip to content

chore(individual-pkg-gen): set the alpha version in alpha module's package.json files if present#16322

Merged
mergify[bot] merged 3 commits intoaws:v2-mainfrom
madeline-k:v2/set-alphaversion-in-package.json-files
Sep 2, 2021
Merged

chore(individual-pkg-gen): set the alpha version in alpha module's package.json files if present#16322
mergify[bot] merged 3 commits intoaws:v2-mainfrom
madeline-k:v2/set-alphaversion-in-package.json-files

Conversation

@madeline-k
Copy link
Copy Markdown
Contributor

@madeline-k madeline-k commented Sep 1, 2021

This change sets the version key in each alpha module's package.json file to the alphaVersion that was created in this PR: #16043

And, also sets the version of each dependency on another alpha module to the same version.

Depends on: #16321

Part of: #15591


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 1, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 1, 2021
@madeline-k madeline-k requested review from a team and njlynch September 1, 2021 14:33
@njlynch njlynch changed the title chore(individual-pkg-gen): set the correct version in alpha module's package.json files chore(individual-pkg-gen): set the alpha version in alpha module's package.json files if present Sep 1, 2021
@njlynch njlynch added the pr/do-not-merge This PR should not be merged at this time. label Sep 1, 2021
Copy link
Copy Markdown
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple. Love it.

Marking as do-not-merge while we wait for the related PR to be merged forward to v2. Alternatively, you could cherry-pick that commit and add it to this one to get this merged sooner.

mergify bot pushed a commit that referenced this pull request Sep 1, 2021
This will be used by a change in `tools/individual-pkg-gen/copy-files-removing-deps.ts` on the `v2-main` branch, so that the `transform` step can correctly set the `version` key and the version for each dependency in each alpha module's `package.json` file.

See #16322 for usage. 

Part of #15591 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@madeline-k madeline-k removed the pr/do-not-merge This PR should not be merged at this time. label Sep 2, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f906422
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9c94563 into aws:v2-main Sep 2, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

madeline-k added a commit to madeline-k/aws-cdk that referenced this pull request Sep 2, 2021
This will be used by a change in `tools/individual-pkg-gen/copy-files-removing-deps.ts` on the `v2-main` branch, so that the `transform` step can correctly set the `version` key and the version for each dependency in each alpha module's `package.json` file.

See aws#16322 for usage. 

Part of aws#15591 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
This will be used by a change in `tools/individual-pkg-gen/copy-files-removing-deps.ts` on the `v2-main` branch, so that the `transform` step can correctly set the `version` key and the version for each dependency in each alpha module's `package.json` file.

See aws#16322 for usage. 

Part of aws#15591 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
This will be used by a change in `tools/individual-pkg-gen/copy-files-removing-deps.ts` on the `v2-main` branch, so that the `transform` step can correctly set the `version` key and the version for each dependency in each alpha module's `package.json` file.

See aws#16322 for usage. 

Part of aws#15591 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
madeline-k added a commit to madeline-k/aws-cdk that referenced this pull request Oct 13, 2021
…ckage.json files if present (aws#16322)

This change sets the `version` key in each alpha module's `package.json` file to the alphaVersion that was created in this PR: aws#16043

And, also sets the version of each dependency on another alpha module to the same version.

Depends on: aws#16321

Part of: aws#15591

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Oct 14, 2021
…ckage.json files if present (#16965)

This change was already approved and merged in: #16322. It somehow got removed from the `v2-main` branch since originally being merged. This PR is just a cherry-pick of the original commit. 

---

This change sets the `version` key in each alpha module's `package.json` file to the alphaVersion that was created in this PR: #16043

And, also sets the version of each dependency on another alpha module to the same version.

Depends on: #16321

Part of: #15591

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ckage.json files if present (aws#16965)

This change was already approved and merged in: aws#16322. It somehow got removed from the `v2-main` branch since originally being merged. This PR is just a cherry-pick of the original commit. 

---

This change sets the `version` key in each alpha module's `package.json` file to the alphaVersion that was created in this PR: aws#16043

And, also sets the version of each dependency on another alpha module to the same version.

Depends on: aws#16321

Part of: aws#15591

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants