feat(aws-route53-targets): Support for Elastic Beanstalk environment URLs#16305
Merged
mergify[bot] merged 18 commits intomasterfrom Oct 28, 2021
Merged
feat(aws-route53-targets): Support for Elastic Beanstalk environment URLs#16305mergify[bot] merged 18 commits intomasterfrom
mergify[bot] merged 18 commits intomasterfrom
Conversation
…README doc update
|
|
924c117 to
ebfd5f2
Compare
njlynch
suggested changes
Oct 7, 2021
packages/@aws-cdk/aws-route53-targets/lib/elastic-beanstalk-environment-target.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-targets/lib/elastic-beanstalk-environment-target.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-targets/lib/elastic-beanstalk-environment-target.ts
Show resolved
Hide resolved
njlynch
reviewed
Oct 12, 2021
| } | ||
|
|
||
| const dnsName = this.environmentEndpoint; | ||
| const region = cdk.Fn.select(2, cdk.Fn.split('.', dnsName)); |
Contributor
There was a problem hiding this comment.
If we're not allowing Tokens (above), then this can be a simple dnsName.split instead of the Fn.split.
njlynch
approved these changes
Oct 12, 2021
Contributor
njlynch
left a comment
There was a problem hiding this comment.
Tentative approval.
I'll let you decide if you have the time to support Tokens here, which is definitely something we should eventually support for this class, or if we can add it in a follow-up sometime later.
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…URLs (aws#16305) ## Summary This PR adds a new Route53 target `ElasticBeanstalkEnvironmentTarget` for creating RecordSets that target Elastic Beanstalk environment URLs. E.g. ```ts const ebsEnvironmentUrl = 'mysampleenvironment.xyz.us-east-1.elasticbeanstalk.com'; new route53.ARecord(this, 'AliasRecord', { zone, target: route53.RecordTarget.fromAlias(new alias.ElasticBeanstalkEnvironmentTarget(ebsEnvironmentUrl)), }); ``` [How to find your Elastic Beanstalk environment URL](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-beanstalk-environment.html#routing-to-beanstalk-environment-get-domain-name) Fixes: aws#3206 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new Route53 target
ElasticBeanstalkEnvironmentTargetfor creating RecordSets that target Elastic Beanstalk environment URLs.E.g.
How to find your Elastic Beanstalk environment URL
Fixes: #3206
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license