feat(stepfunctions-tasks): support allocation strategies in EMR CreateCluster#16296
Merged
mergify[bot] merged 13 commits intoaws:masterfrom Aug 31, 2021
Merged
feat(stepfunctions-tasks): support allocation strategies in EMR CreateCluster#16296mergify[bot] merged 13 commits intoaws:masterfrom
mergify[bot] merged 13 commits intoaws:masterfrom
Conversation
|
|
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Contributor
Author
|
@BenChaimberg I made a PR and you asked to mention you as reviewer. |
BenChaimberg
previously requested changes
Aug 31, 2021
Contributor
BenChaimberg
left a comment
There was a problem hiding this comment.
Please revert the whitespace changes you made to the method definitions
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
Contributor
Author
|
Thanks for quick feedback @BenChaimberg. I have addressed your concerns |
BenChaimberg
previously requested changes
Aug 31, 2021
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
…luster.ts Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
…luster.ts Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
Pull request has been modified.
…luster.ts Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
Contributor
Author
|
@BenChaimberg final touches added |
BenChaimberg
approved these changes
Aug 31, 2021
Contributor
|
Still need to fix linting errors (run |
BenChaimberg
suggested changes
Aug 31, 2021
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
BenChaimberg
previously approved these changes
Aug 31, 2021
Pull request has been modified.
BenChaimberg
previously approved these changes
Aug 31, 2021
Pull request has been modified.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
BenChaimberg
approved these changes
Aug 31, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16252
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license