Skip to content

fix(aws-rds): fromDatabaseInstanceAttributes incorrectly stringifies ports with tokens#16286

Merged
mergify[bot] merged 6 commits intoaws:masterfrom
comcalvi:tokensDocDB
Aug 31, 2021
Merged

fix(aws-rds): fromDatabaseInstanceAttributes incorrectly stringifies ports with tokens#16286
mergify[bot] merged 6 commits intoaws:masterfrom
comcalvi:tokensDocDB

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi commented Aug 30, 2021

Closes #11813. Fixes port with tokens being incorrectly stringified in fromDatabaseInstanceAttributes().


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 30, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 30, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 30, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@comcalvi comcalvi changed the title (aws-rds): fromDatabaseInstanceAttributes incorrectly stringifies ports with tokens fix(aws-rds): fromDatabaseInstanceAttributes incorrectly stringifies ports with tokens Aug 30, 2021
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 31, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 21effd3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 41b831a into aws:master Aug 31, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 31, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
…ports with tokens (aws#16286)

Closes aws#11813. Fixes `port` with tokens being incorrectly stringified in `fromDatabaseInstanceAttributes()`.

----


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…ports with tokens (aws#16286)

Closes aws#11813. Fixes `port` with tokens being incorrectly stringified in `fromDatabaseInstanceAttributes()`.

----


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(rds/docdb): fromDatabaseInstanceAttributes stringifies number tokens incorrectly

3 participants