chore: migrate a few modules from nodeunit-shim to jest#16258
Merged
mergify[bot] merged 7 commits intomasterfrom Aug 28, 2021
Merged
chore: migrate a few modules from nodeunit-shim to jest#16258mergify[bot] merged 7 commits intomasterfrom
mergify[bot] merged 7 commits intomasterfrom
Conversation
added 4 commits
August 27, 2021 13:47
|
|
BenChaimberg
previously requested changes
Aug 27, 2021
Contributor
BenChaimberg
left a comment
There was a problem hiding this comment.
it seems like a bunch of the top-level describes are accidentally duplicated
packages/@aws-cdk/aws-codepipeline-actions/test/bitbucket/bitbucket-source-action.test.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/test/cloudformation/pipeline-actions.test.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/test/codebuild/codebuild-action.test.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/test/pipeline.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-autoscaling/test/auto-scaling-group.test.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Aug 27, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Sep 6, 2021
Part of the the effort to homogenize our testing environment in the AWS CDK repo involves removing the nodeunit-shim and using standard jest. This change applies this to a few modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
Part of the the effort to homogenize our testing environment in the AWS CDK repo involves removing the nodeunit-shim and using standard jest. This change applies this to a few modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the the effort to homogenize our testing environment in
the AWS CDK repo involves removing the nodeunit-shim and
using standard jest.
This change applies this to a few modules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license