Skip to content

feat(assertions): 'not' matcher#16240

Merged
mergify[bot] merged 3 commits intomasterfrom
nija-at/assertions-notmatch
Aug 27, 2021
Merged

feat(assertions): 'not' matcher#16240
mergify[bot] merged 3 commits intomasterfrom
nija-at/assertions-notmatch

Conversation

@nija-at
Copy link
Copy Markdown
Contributor

@nija-at nija-at commented Aug 26, 2021

Supply a 'not' matcher that can be used to invert the matching pattern

relates #15868


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested a review from a team August 26, 2021 11:42
@nija-at nija-at self-assigned this Aug 26, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 26, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 26, 2021
Copy link
Copy Markdown
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Super useful. One ask for tests, rest looks great.

@nija-at nija-at requested a review from BenChaimberg August 27, 2021 08:19
@nija-at nija-at added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Aug 27, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0c8de61
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b838f95 into master Aug 27, 2021
@mergify mergify bot deleted the nija-at/assertions-notmatch branch August 27, 2021 13:48
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
Supply a 'not' matcher that can be used to invert the matching pattern

relates aws#15868

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
Supply a 'not' matcher that can be used to invert the matching pattern

relates aws#15868

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants