feat(cognito): identity pools by smguggen · Pull Request #16190 · aws/aws-cdk

smguggen · 2021-08-24T02:26:45Z

Adds Identity Pool L2 Construct which to date has not been implemented. Since Identity Pool's can't be used without default auth and unauth roles, also incorporated the L1 CfnIdentityPoolRoleAttachment into the Construct. Contains unit and integration tests as well as fully updated ReadMe.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…nto identity-pool

Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.16. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.13...v4.4.16) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Chaimberg <chaimber@amazon.com>

* chore(deps-dev): bump jszip from 3.6.0 to 3.7.0 Bumps [jszip](https://github.com/Stuk/jszip) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/Stuk/jszip/releases) - [Changelog](https://github.com/Stuk/jszip/blob/master/CHANGES.md) - [Commits](Stuk/jszip@v3.6.0...v3.7.0) --- updated-dependencies: - dependency-name: jszip dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * updates package.json as well and removes unneeded types dependency Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Chaimberg <chaimber@amazon.com>

Error in the documentation and type checking. Fixed both the readme and the related PR (integ test used a `Field` type so it still works as intended). Related PR: aws#10078 Fixes: aws#16071 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>

corymhall · 2022-01-05T19:19:35Z

packages/@aws-cdk/aws-cognito-identitypool/test/integ.identitypool.expected.json

+      "Properties": {
+        "AllowUnauthenticatedIdentities": false,
+        "AllowClassicFlow": true,
+        "CognitoIdentityProviders": [],


@smguggen it looks like the integration tests are not testing the cognito identity providers.

@corymhall Oh wow, thanks for catching that, the user pool in the integ test actually has no identity providers in it. So I added 2 identity providers (so there would be more than 1 provider name in the pool) and ran it both ways: looping through userPool.identityProviders to get the providerName and then using userPool.userPoolProviderName. The userPool.userPoolProviderName did just like you said and used the same provider over and over while the identityProviders included the entire list of providers. Now I'm just waiting to see if the stack succeeds with the identityProvider names to confirm that all of this works.

@smguggen did the integration tests succeed? I tried running them and received a lot of errors.

How are you generating the integ.identitypool.expected.json?

You should generate the expected template by running

yarn integ integ.identitypool.js

That will actually perform a deployment and make sure it is successful and then output the template in the expected.json file.

@corymhall Well I just completely whiffed on that one, didn't I? 😂😂😂

The reason I was so sure that worked (yarn.integ had always given me credentials problems) was that I was using this as an extension library in one of my side projects, and in that project I was using this feature. Well, turns out I'd forgotten about a bug I fixed here weeks ago that was causing IdentityPool.cognitoIdentityProviders to always be an empty array, so the Identity Pool had only been using an OIDC provider directly and wasn't using the user pool at all.

Anyway lessons learned. Thanks for being so thorough about that, changes have been made, so tell me what you think.

…-pool

corymhall

@smguggen looking good! Just a couple more comments on the new bind implementation.

...ages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-user-pool-authentication-provider.ts

…-pool

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

Pull request has been modified.

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

…nto identity-pool

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

smguggen · 2022-01-13T18:23:09Z

@corymhall One pending suggestion and then I can push changes

…nto identity-pool

corymhall

@smguggen great job on this!

mergify · 2022-01-14T12:52:09Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-01-14T13:37:35Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: c3e9e6c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-01-14T13:37:59Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Adds Identity Pool L2 Construct which to date has not been implemented. Since Identity Pool's can't be used without default auth and unauth roles, also incorporated the L1 CfnIdentityPoolRoleAttachment into the Construct. Contains unit and integration tests as well as fully updated ReadMe. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

smguggen and others added 30 commits August 16, 2021 12:49

Add Identity Pool construct

1aa3425

Bug fixes

4dba4bb

Bug fixes

a6acecf

Formatting

f8d08e7

Add construct methods

fef36fc

Remove flat

ce57950

Fix issues

7b27b2b

Add first unit test

0ebe323

Test user pools

cb172de

Add user pool unit tests

8be14a1

Test openid and saml

c0a0b1e

Add custom provider tests

9a0be08

Add unit tests for streams, events, push sync

4f4019a

Add Role Mapping unit tests

4e03f43

Add role mapping unit tests

3adb6fb

Add integration test for identity pool

6a12d08

Add to README

2f36b50

Add more to README

20c2350

Reformat README

d683585

Reformat README

8fedf01

Update README

eb18aee

Updated expected template for integration test

af156fc

Merge branch 'identity-pool' of https://github.com/smguggen/aws-cdk i…

b826910

…nto identity-pool

Update integration tests

ab514b2

add comcalvi to mergigy

5409870

chore(deps): bump tar from 6.1.0 to 6.1.8 (aws#16109)

7a5619b

---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(cfnspec): cloudformation spec v39.10.0 (aws#16114)

4091527

Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>

corymhall reviewed Jan 5, 2022

View reviewed changes

smguggen added 3 commits January 6, 2022 02:15

Add cognitoidentityproviders to integration test

baf5cbb

Merge branch 'master' of https://github.com/aws/aws-cdk into identity…

672cf8d

…-pool

Fix bug in integ

6d66a84

smguggen requested a review from corymhall January 6, 2022 03:52

Fix persistent identity provider issue

099c63a

corymhall previously requested changes Jan 13, 2022

View reviewed changes

smguggen and others added 2 commits January 13, 2022 17:26

Merge branch 'master' of https://github.com/aws/aws-cdk into identity…

b1c0683

…-pool

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

15791d3

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

smguggen and others added 7 commits January 13, 2022 11:29

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

740f20f

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

5fbc9dd

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

ec08281

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

a46cc89

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

e9fccd2

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

Merge branch 'identity-pool' of https://github.com/smguggen/aws-cdk i…

36fd50a

…nto identity-pool

Update packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-us…

9972081

…er-pool-authentication-provider.ts Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>

smguggen added 3 commits January 13, 2022 20:27

Update tests

b226de5

Merge branch 'identity-pool' of https://github.com/smguggen/aws-cdk i…

03ddbcd

…nto identity-pool

Update yarn.lock

41d263e

smguggen requested a review from corymhall January 13, 2022 21:33

corymhall approved these changes Jan 14, 2022

View reviewed changes

Merge branch 'master' into identity-pool

c3e9e6c

mergify bot merged commit 59fe395 into aws:master Jan 14, 2022

Tietew mentioned this pull request Feb 14, 2024

fix(cognito-identitypool-alpha): inconvenient IdentityPoolProviderUrl.userPool() #29025

Merged

1 task

Conversation

smguggen commented Aug 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corymhall Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

smguggen Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

corymhall Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

corymhall Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

smguggen Jan 8, 2022

Choose a reason for hiding this comment

Uh oh!

corymhall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smguggen commented Jan 13, 2022

Uh oh!

corymhall left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jan 14, 2022

Uh oh!

aws-cdk-automation commented Jan 14, 2022

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jan 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

smguggen commented Aug 24, 2021 •

edited

Loading

smguggen Jan 6, 2022 •

edited

Loading