feat(aws-cloudfront-origins): add custom headers to S3Origin#16161
feat(aws-cloudfront-origins): add custom headers to S3Origin#16161mergify[bot] merged 17 commits intoaws:masterfrom
Conversation
|
|
|
@njlynch What are your thoughts on sanitizing custom headers vs throwing errors if forbidden headers are present (which is implemented in this PR)? |
njlynch
left a comment
There was a problem hiding this comment.
This looks good; thanks again for taking the initiative here.
I've got a few minor nitpicks that I think will improve the (contributor|developer) experience.
packages/@aws-cdk/aws-cloudfront-origins/test/integ.s3-origin-custom-headers.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-cloudfront-origins/test/s3-origin.test.ts
Outdated
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes aws#16160. @njlynch Can you please review this when time permits and see if it needs any further polishing. cc @nwitte-rocketloans ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes aws#16160. @njlynch Can you please review this when time permits and see if it needs any further polishing. cc @nwitte-rocketloans ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #16160.
@njlynch Can you please review this when time permits and see if it needs any further polishing.
cc @nwitte-rocketloans
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license