Skip to content

chore(rds): add new versions of MariaDB, MySQL and SQL Server engines#16115

Merged
mergify[bot] merged 7 commits intoaws:masterfrom
wuhkuh:update-rds-versions
Aug 26, 2021
Merged

chore(rds): add new versions of MariaDB, MySQL and SQL Server engines#16115
mergify[bot] merged 7 commits intoaws:masterfrom
wuhkuh:update-rds-versions

Conversation

@wuhkuh
Copy link
Copy Markdown
Contributor

@wuhkuh wuhkuh commented Aug 18, 2021

Added every change as a separate commit, feel free to rebase as you see fit.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 18, 2021

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@wuhkuh wuhkuh force-pushed the update-rds-versions branch from 0a47ca5 to 9e59ac0 Compare August 18, 2021 09:09
@wuhkuh wuhkuh changed the title Update RDS engine versions chore(rds): update engine versions Aug 18, 2021
@wuhkuh
Copy link
Copy Markdown
Contributor Author

wuhkuh commented Aug 18, 2021

err - PROP @aws-cdk/aws-rds.SqlServerEngineVersion.VER_15_00_4043_23_V1: has been removed [removed:@aws-cdk/aws-rds.SqlServerEngineVersion.VER_15_00_4043_23_V1]
(...)
Some packages seem to have undergone breaking API changes. Please avoid.

At best this version could point towards the correct version to preserve API compatibility, but keep in mind there's nothing to preserve—this version simply doesn't exist. Preserving compatibility would also nullify the point of type-safe versioning.

Strongly in favor of using the escape hatch (overriding this warning) and patching this up.

@peterwoodworth peterwoodworth added @aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort labels Aug 19, 2021
skinny85
skinny85 previously requested changes Aug 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wuhkuh!

@skinny85 skinny85 changed the title chore(rds): update engine versions chore(rds): add new versions of MariaDB, MySQL and SQL Server engines Aug 23, 2021
@skinny85
Copy link
Copy Markdown
Contributor

skinny85 commented Aug 23, 2021

err - PROP @aws-cdk/aws-rds.SqlServerEngineVersion.VER_15_00_4043_23_V1: has been removed [removed:@aws-cdk/aws-rds.SqlServerEngineVersion.VER_15_00_4043_23_V1]
(...)
Some packages seem to have undergone breaking API changes. Please avoid.

At best this version could point towards the correct version to preserve API compatibility, but keep in mind there's nothing to preserve—this version simply doesn't exist. Preserving compatibility would also nullify the point of type-safe versioning.

Strongly in favor of using the escape hatch (overriding this warning) and patching this up.

Instead of removing the VER_15_00_4043_23_V1 constant, deprecate it.

@wuhkuh wuhkuh force-pushed the update-rds-versions branch from 9e59ac0 to 8299aa8 Compare August 26, 2021 12:44
@mergify mergify bot dismissed skinny85’s stale review August 26, 2021 12:44

Pull request has been modified.

@wuhkuh wuhkuh force-pushed the update-rds-versions branch from 8299aa8 to 1f588fd Compare August 26, 2021 12:48
@wuhkuh
Copy link
Copy Markdown
Contributor Author

wuhkuh commented Aug 26, 2021

Requested changes applied 😄

skinny85
skinny85 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @wuhkuh!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 26, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 39daf89
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5cec2f8 into aws:master Aug 26, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@wuhkuh @hollanddd
chore(rds): add new versions of MariaDB, MySQL and SQL Server engines (…
f8c08be 
…aws#16115)

Added every change as a separate commit, feel free to rebase as you see fit.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@wuhkuh @TikiTDO
chore(rds): add new versions of MariaDB, MySQL and SQL Server engines (…
10d8a55 
…aws#16115)

Added every change as a separate commit, feel free to rebase as you see fit.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@wuhkuh @david-doyle-as24
chore(rds): add new versions of MariaDB, MySQL and SQL Server engines (…
668534e 
…aws#16115)

Added every change as a separate commit, feel free to rebase as you see fit.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skinny85 skinny85 skinny85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skinny85 skinny85

Labels

@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wuhkuh @skinny85 @aws-cdk-automation @BenChaimberg @peterwoodworth