chore: jsii-rosetta cannot be found when building individual packages#16112
Merged
mergify[bot] merged 4 commits intoaws:v2-mainfrom Aug 19, 2021
otaviomacedo:create-sym-links
Merged
chore: jsii-rosetta cannot be found when building individual packages#16112mergify[bot] merged 4 commits intoaws:v2-mainfrom otaviomacedo:create-sym-links
mergify[bot] merged 4 commits intoaws:v2-mainfrom
otaviomacedo:create-sym-links
Conversation
|
|
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the steps of the build of experimental packages is to run
yarn --silent jsii-rosetta extractfor each package. Since yarn can't find thejsii-rosettaexecutable, the build fails. For some reason, runningyarn bin jsii-rosettaat theindividual-packagesfolder shows that yarn can find it at the root folder'snode_modules, but running the same command inside each individual package result in "error Couldn't find a binary named "jsii-rosetta"".This change adds a
.binsymlink to each individual package'snode_modulepointing to the root folder'snode_modules/.binfolder.Fixes #15825
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license