-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Extract jsii-rosetta samples from the unstable modules #15825
Copy link
Copy link
Closed
Labels
aws-cdk-libRelated to the aws-cdk-lib packageRelated to the aws-cdk-lib packageeffort/mediumMedium work item – several days of effortMedium work item – several days of effortfeature-requestA feature should be added or improved.A feature should be added or improved.p1
Description
In the current build of unstable modules implemented in #15722, the rosetta:extract task is not being executed by the scripts/transform.sh script, even if you pass the --extract flag to it. That's because the jsii-rosetta tool can't be found in the inner monorepo in packages/individual-packages for some reason. We need to investigate why, and find a solution that makes it work, and then update scripts/transform.sh to execute the build+test+extract task on the unstable modules if --extract is passed to it.
Things that have been tried, and rejected:
- Adding
jsii-rosettaas a dependency inpackages/individual-packages/package.json(doesn't work, the binary still can't be found). - Adding
jsii-rosettaas a dependency to each copied unstable module (this works, but @nija-at rejected it, because it requires changing apkglintrule to allow direct JSII dependencies).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
aws-cdk-libRelated to the aws-cdk-lib packageRelated to the aws-cdk-lib packageeffort/mediumMedium work item – several days of effortMedium work item – several days of effortfeature-requestA feature should be added or improved.A feature should be added or improved.p1