chore: move the build of the experimental modules to a separate script#15722
Conversation
62e5903 to
3547469
Compare
|
@nija-at included all your comments, would appreciate a re-review! |
I'm out for the day today. |
nija-at
left a comment
There was a problem hiding this comment.
Sorry it took longer to review this. I had to deep dive into the scripts a little to provide useful feedback.
Instead of building the experimental modules as part of the main monorepo, move their generation into a separate script, mastered in `scripts/individual-packages.sh`.
a8fa253 to
3e4a464
Compare
a2a2476 to
1a4b838
Compare
|
@nija-at thanks for the review. Included all of your comments, would appreciate a re-review! |
nija-at
left a comment
There was a problem hiding this comment.
Looking much better now. Still a few more things.
Please take a look at my responses from the previous review. I've left the comments that need addressing as 'unresolved'.
…SLint rule instead of turning it off.
…V1 package included them.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@nija-at incorporated all of your comments from the last review, should be good to go! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
As part of #15722, the jsii targets for experimental packages on the v2 branch were changed to include an 'alpha' identifier so the package and module names would more obviously reflect the stability of the packages. However, since this change was made directly to the package.json files, this means that all usages of these targets across the source were impacted, including usages via ubergen. The impact of this is that the L1s published to aws-cdk-lib were incorrectly published under this 'alpha' module instead of their normal location. L1s should still go under the standard location, as they are stable; only the experimental L2s should be impacted by the alpha designator. fixes #15845
…mation As part of #15722, the decision was made to change the package.json files for experimental packages to add 'alpha' identifiers. This ends up causing issues for our ubergen-ed packages (i.e., aws-cdk-lib), which then try to include L1s for these packages under the 'alpha' namespaces. Instead, switch (back) to adding the alpha identifiers as part of the package transformation step. Reverted the change to the pkglint rules, and re-ran `yarn pkglint` to update the package.json files. I also did some light refactoring, since the method was a bit hard to read. fixes #15845
…mation (#15890) As part of #15722, the decision was made to change the package.json files for experimental packages to add 'alpha' identifiers. This ends up causing issues for our ubergen-ed packages (i.e., aws-cdk-lib), which then try to include L1s for these packages under the 'alpha' namespaces. Instead, switch (back) to adding the alpha identifiers as part of the package transformation step. Reverted the change to the pkglint rules, and re-ran `yarn pkglint` to update the package.json files. I also did some light refactoring, since the method was a bit hard to read. fixes #15845 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Instead of building the experimental modules as part of the main monorepo,
move their generation into a separate script,
mastered in
scripts/transform.sh.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license