feat(ecr-assets): control docker image asset hash#16070
feat(ecr-assets): control docker image asset hash#16070mergify[bot] merged 8 commits intoaws:masterfrom
Conversation
Docker build args are meant for build system specific configuration like http proxy or CodeArtifact tokens. Give the user an option to not hash build args so the DockerImageAsset hash can remain consistent. An inconsistent hash means the asset is built every synth and that wastes time and space. closes aws#15936
|
|
eladb
left a comment
There was a problem hiding this comment.
Let's call this option invalidation and have a boolean flag for each hash component.
Something like this:
{
invalidation: {
buildArgs: false,
target: false,
// etc
}
}So users will be able to opt out from using any component when a hash is calculated.
|
@eladb done. I was initially thinking of doing the same, but then couldn't think of a use case where those would be useful. But I guess it can't hurt to have them around. Though skipping |
|
@eladb anything else I need to do to make this mergeable? This issue is a huge resource waste for us with the number of pipelines we have. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
924c117 to
ebfd5f2
Compare
|
@eladb it seems like mergify skipped this PR for the latest release. Any idea how I can fix it? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Docker build args are meant for build system specific configuration like http proxy or CodeArtifact tokens. Give the user an option to not hash build args so the DockerImageAsset hash can remain consistent even when using build args. An inconsistent hash means the asset is built every synth and that wastes time and space. This change is backwards compatible as the default hashing behavior remains the same. closes #15936 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Docker build args are meant for build system specific configuration like http proxy or CodeArtifact tokens. Give the user an option to not hash build args so the DockerImageAsset hash can remain consistent even when using build args. An inconsistent hash means the asset is built every synth and that wastes time and space. This change is backwards compatible as the default hashing behavior remains the same. closes aws#15936 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Docker build args are meant for build system specific configuration like http proxy or CodeArtifact tokens. Give the user an option to not hash build args so the DockerImageAsset hash can remain consistent even when using build args. An inconsistent hash means the asset is built every synth and that wastes time and space.
This change is backwards compatible as the default hashing behavior remains the same.
closes #15936
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license