feat(elasticloadbalancingv2): ALPN policy support for NLB listener#15956
Merged
mergify[bot] merged 6 commits intoaws:masterfrom Sep 3, 2021
Merged
feat(elasticloadbalancingv2): ALPN policy support for NLB listener#15956mergify[bot] merged 6 commits intoaws:masterfrom
mergify[bot] merged 6 commits intoaws:masterfrom
Conversation
|
|
8b651d2 to
19e6b01
Compare
project0
commented
Aug 13, 2021
| } | ||
|
|
||
| if (proto !== Protocol.TLS && props.alpnPolicy) { | ||
| throw new Error('Protocol must be TLS when alpnPolicy have been specified'); |
Contributor
Author
There was a problem hiding this comment.
Should we change this to aspect errors (i just adopted the same pattern from above)?
njlynch
previously approved these changes
Aug 27, 2021
Contributor
njlynch
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Pull request has been modified.
njlynch
previously approved these changes
Sep 3, 2021
Pull request has been modified.
njlynch
approved these changes
Sep 3, 2021
Contributor
njlynch
left a comment
There was a problem hiding this comment.
Fixed a broken docstring that was failing the build. Should pass now.
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Sep 6, 2021
…ws#15956) Allow specifying the ALPN Policy ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
…ws#15956) Allow specifying the ALPN Policy ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying the ALPN Policy
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license