chore(assertions): explicit feature flags to produce a consistent template during tests#15924
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Aug 6, 2021
otaviomacedo:template-nss-false
Merged
chore(assertions): explicit feature flags to produce a consistent template during tests#15924mergify[bot] merged 2 commits intoaws:masterfrom otaviomacedo:template-nss-false
mergify[bot] merged 2 commits intoaws:masterfrom
otaviomacedo:template-nss-false
Conversation
…sure that the generated stack has no bootstrap elements
|
|
nija-at
reviewed
Aug 6, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
Can you provide a little more context and explanation of the fix in the PR description?
Think of someone looking at this commit 3 months later, trying to see why this flag was added. The description should make enough sense to them.
false to make sure that the generated stack has no bootstrap elements
nija-at
approved these changes
Aug 6, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…plate during tests (aws#15924) In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
…plate during tests (aws#15924) In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v1, the default value of the
@aws-cdk/core:newStyleStackSynthesisflag isfalse. As a consequence,Template.fromStack()generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag istrue. So this test fails in the v2 branch. By explicitly setting the flag tofalse, we ensure that the tests passes on both v1 and v2, regardless of the default values.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license