Skip to content

fix(stepfunctions-tasks): instance type cannot be provided to SageMakerCreateTransformJob as input path#15726

Merged
mergify[bot] merged 8 commits intoaws:masterfrom
syeehyn:master
Jul 26, 2021
Merged

fix(stepfunctions-tasks): instance type cannot be provided to SageMakerCreateTransformJob as input path#15726
mergify[bot] merged 8 commits intoaws:masterfrom
syeehyn:master

Conversation

@syeehyn
Copy link
Copy Markdown
Contributor

@syeehyn syeehyn commented Jul 22, 2021

as referred in #11605 in SageMakerCreateTransformJob has the same kind of issue.

similar solution can be found at #11749

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 22, 2021

BenChaimberg
BenChaimberg previously requested changes Jul 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test(s) to ensure both ways of providing an instance type produce a valid output

@BenChaimberg BenChaimberg mentioned this pull request Jul 22, 2021
Closed
@mergify mergify bot dismissed BenChaimberg’s stale review July 25, 2021 21:58

Pull request has been modified.

syeehyn and others added 2 commits July 25, 2021 18:24
@syeehyn
Copy link
Copy Markdown
Contributor Author

syeehyn commented Jul 25, 2021

Please add test(s) to ensure both ways of providing an instance type produce a valid output

Added test for the jsonString path. w.r.t this PR #14064

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 26, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9b0b084
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6f2384d into aws:master Jul 26, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
@syeehyn @TikiTDO
fix(stepfunctions-tasks): instance type cannot be provided to SageMak…
7b1d689 
…erCreateTransformJob as input path (aws#15726)

as referred in aws#11605 in SageMakerCreateTransformJob has the same kind of issue.

similar solution can be found at aws#11749


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@syeehyn @hollanddd
fix(stepfunctions-tasks): instance type cannot be provided to SageMak…
c06c709 
…erCreateTransformJob as input path (aws#15726)

as referred in aws#11605 in SageMakerCreateTransformJob has the same kind of issue.

similar solution can be found at aws#11749


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenChaimberg BenChaimberg BenChaimberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenChaimberg BenChaimberg

Labels

@aws-cdk/aws-stepfunctions-tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@syeehyn @aws-cdk-automation @BenChaimberg @peterwoodworth