Skip to content

docs(pipelines): add migration guide#15696

Merged
mergify[bot] merged 4 commits intomasterfrom
huijbers/pipelines-migration-guide
Jul 22, 2021
Merged

docs(pipelines): add migration guide#15696
mergify[bot] merged 4 commits intomasterfrom
huijbers/pipelines-migration-guide

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jul 21, 2021

Add a migration guide for original to modern API.

Rendered version


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add a migration guide for original to modern API.
@rix0rrr rix0rrr requested a review from a team July 21, 2021 15:28
@rix0rrr rix0rrr self-assigned this Jul 21, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 21, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 21, 2021
Copy link
Copy Markdown
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just cosmetics since it's documentation

all commands necessary to do a full CDK build and synth, so do include
installing dependencies and running the CDK CLI. Example:

```ts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing the "before" picture would be helpful here

### Custom CodePipeline Actions

See the section [**Arbitrary CodePipeline actions** in the
main `README`](README.md) for an example of how to inject arbitrary
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add an anchor link?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can, but I don't like anchor links to markdowns: they're implementation-depdendent. OTOH, we're definitely on GitHub anyway...

Co-authored-by: Ben Chaimberg <chaimber@amazon.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9eef004
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9022d6f into master Jul 22, 2021
@mergify mergify bot deleted the huijbers/pipelines-migration-guide branch July 22, 2021 10:37
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
Add a migration guide for original to modern API.

[Rendered version](https://github.com/aws/aws-cdk/blob/huijbers/pipelines-migration-guide/packages/@aws-cdk/pipelines/ORIGINAL_API.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Add a migration guide for original to modern API.

[Rendered version](https://github.com/aws/aws-cdk/blob/huijbers/pipelines-migration-guide/packages/@aws-cdk/pipelines/ORIGINAL_API.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants