Skip to content

fix(pipelines): permissions check in legacy API does not work#15660

Merged
mergify[bot] merged 3 commits intomasterfrom
huijbers/legacy-stage-check
Jul 20, 2021
Merged

fix(pipelines): permissions check in legacy API does not work#15660
mergify[bot] merged 3 commits intomasterfrom
huijbers/legacy-stage-check

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jul 20, 2021

We were still passing a stack name instead of a stage path,
causing the check to not work correctly.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We were still passing a stack name instead of a stage path,
causing the check to not work correctly.
@rix0rrr rix0rrr requested review from BryanPan342 and nija-at July 20, 2021 10:47
@rix0rrr rix0rrr self-assigned this Jul 20, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 20, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 20, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5e3cf2b into master Jul 20, 2021
@mergify mergify bot deleted the huijbers/legacy-stage-check branch July 20, 2021 15:37
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2ffa6fc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
)

We were still passing a stack name instead of a stage path,
causing the check to not work correctly.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
)

We were still passing a stack name instead of a stage path,
causing the check to not work correctly.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants