fix(pipelines): CodeBuildStep.partialBuildSpec not used, buildspec control for legacy API#15625
fix(pipelines): CodeBuildStep.partialBuildSpec not used, buildspec control for legacy API#15625mergify[bot] merged 8 commits intoaws:masterfrom hoegertn:hoegertn-buildspec-props
CodeBuildStep.partialBuildSpec not used, buildspec control for legacy API#15625Conversation
|
|
CodeBuildStep.partialBuildSpec not used, buildspec control for legacy API
| phases: { | ||
| pre_build: { | ||
| commands: ['installCustom', 'install1', 'install2'], | ||
| commands: arrayWith('installCustom'), |
There was a problem hiding this comment.
This does no longer validate the ordering...
| }, | ||
| }, | ||
| }); | ||
| this.buildSpec = props.buildSpec ? codebuild.mergeBuildSpecs(props.buildSpec, buildSpec) : buildSpec; |
There was a problem hiding this comment.
So the idea is that the user can augment the existing build spec, but not override anything. Is that it?
There was a problem hiding this comment.
Not entirely. Some things may be overwritten, but in general they will be merged.
There was a problem hiding this comment.
Yes, that's true. Objects and arrays will be merged. But for primitives (let's say, run-as), the one generated by the action has precedence over the one provided by the user.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@hoegertn it worked for me now, thanks! |
this fixes #15169
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license