feat(lambda-nodejs): source map mode#15621
Conversation
|
|
| * @see https://esbuild.github.io/api/#sourcemap | ||
| */ | ||
| export enum SourceMapMode { | ||
| /** Default sourceMap mode */ |
There was a problem hiding this comment.
Add docstrings from esbuild explaining what each option means
| }); | ||
| }); | ||
|
|
||
| test('esbuild bundling throws when sourceMapMode used with falsy sourceMap', () => { |
There was a problem hiding this comment.
I actually that setting sourceMapMode to a value should imply sourceMap: true (unless explicitly set to false and then I'd expect an error).
The API design tenet is that if you can do the right thing based on the user intent, why yell at them?
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Addresses aws#14857 by adding source map configuration options. Current implementation preferred preserving backwards compatibility with `sourceMap` boolean flag. See issue discussion for an alternative. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Addresses aws#14857 by adding source map configuration options. Current implementation preferred preserving backwards compatibility with `sourceMap` boolean flag. See issue discussion for an alternative. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Addresses #14857 by adding source map configuration options. Current implementation preferred preserving backwards compatibility with
sourceMapboolean flag. See issue discussion for an alternative.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license