feat(servicecatalog): Add stack event notification constraint#15610
Merged
mergify[bot] merged 9 commits intoaws:masterfrom Jul 20, 2021
Merged
feat(servicecatalog): Add stack event notification constraint#15610mergify[bot] merged 9 commits intoaws:masterfrom
mergify[bot] merged 9 commits intoaws:masterfrom
Conversation
|
|
skinny85
previously requested changes
Jul 16, 2021
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Looks great! A few minor comments.
| * @param product A service catalog product. | ||
| * @param topics A list of SNS Topics to receive notifications on events related to the provisioned product. | ||
| */ | ||
| addEventNotifications(product: IProduct, topics: sns.ITopic[], options?: CommonConstraintOptions): void; |
Contributor
There was a problem hiding this comment.
- Not a huge fan of this name. How about
notify(Topic(s))On(Stack)Events()? - I don't love the ergonomics of the
topicsparameter right now - if the most common case is subscribing a single Topic to the events, like I suspect it is, it's not very easy. Maybe we should have two methods - one with a singular name (notifyTopicOnStackEvents()) that takes in a singlesns.Topic, and one with a plural name (notifyTopicsOnStackEvents()) that takes insns.Topic[]?
Contributor
Author
There was a problem hiding this comment.
- sure - I liked the notify verbiage but didn't like what I had for what would be the stackEvents part. I also thought maybe something like
subscribeToEvents. - I got my guidance before based on the original construct which took a list. I don't have many good examples, but using the singular version might be easier here if that hypothesis is true. For one it simplifies the code since we don't need the for loop. The only concern I had was that if you had more than one topic and more than one portfolio-product association it would get very not DRY. Adding just the singular version first sounds fine.
Contributor
Author
There was a problem hiding this comment.
changed this to singular.
packages/@aws-cdk/aws-servicecatalog/lib/private/association-manager.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-servicecatalog/lib/private/association-manager.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-servicecatalog/lib/private/association-manager.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
is this good to go? |
Contributor
Could you resolve the conflicts with |
Add event notification constraint. Allows users to subscribe AWS `SNS` topics to stack updates on their products. Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
Contributor
Author
|
fixed, didn't see merge conflicts before. |
skinny85
reviewed
Jul 20, 2021
packages/@aws-cdk/aws-servicecatalog/lib/private/association-manager.ts
Outdated
Show resolved
Hide resolved
skinny85
approved these changes
Jul 20, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stack event notification constraint.
Allows users to subscribe AWS
SNStopics to stack updates on their products.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Co-authored-by: Dillon Ponzo dponzo18@gmail.com