docs: update constructor declaration for enum-like class in "Design Guidelines"#15520
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Jul 28, 2021
Merged
Conversation
Fix constructor issue with enum like class examples
|
|
skinny85
previously requested changes
Jul 13, 2021
| @@ -617,7 +617,7 @@ export class MyOption { | |||
| public static COMMON_OPTION_1 = new MyOption('common.option-1'); | |||
Contributor
There was a problem hiding this comment.
Can we change the MyProps while we're in the area to read:
export interface MyProps {
readonly option: MyOption;
}(Sorry, I can't comment on that line directly, because it was not changed in the PR)
Contributor
Author
There was a problem hiding this comment.
Sure, I've updated the PR!
Add readonly to MyProps
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
…uidelines" (aws#15520) Fix constructor issue with enum like class examples ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…uidelines" (aws#15520) Fix constructor issue with enum like class examples ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix constructor issue with enum like class examples
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license