docs(appmesh): Suggest improvements for App Mesh readme#15506
docs(appmesh): Suggest improvements for App Mesh readme#15506mergify[bot] merged 11 commits intomasterfrom unknown repository
Conversation
|
|
|
Thanks @jerry-aws for review the |
|
@dfezzie would you mind reviewing this PR? Thanks! |
|
@jerry-aws - Would it be easier for you if I submit separate PR based on your change since there is a merge conflict? |
|
@Seiya6329 fixed merge conflicts. |
|
@jerry-aws - Thanks for the review. It is looking great and much easier to read. I have minor comments. |
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
|
@Seiya6329 Accepted those changes; this should be good to go. |
|
@jerry-aws Thanks for the update! Looks like you have overwritten following changes during the last commit. Were they intentional? |
|
@Seiya6329 No, unintentional. I'll restore those changes. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@Seiya6329 The inadvertent reversions have been addressed and it's building now. Should be good to go! |
|
@jerry-aws Looks great! Thank you very much! |
|
@skinny85 I reviewed the change and it looks good. Could you approve it to merge? |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Did a quick review of this README and made some generally minor suggestions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Did a quick review of this README and made some generally minor suggestions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Did a quick review of this README and made some generally minor suggestions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license