feat(apigatewayv2-integrations): http private integrations - tls config#15469
feat(apigatewayv2-integrations): http private integrations - tls config#15469mergify[bot] merged 8 commits intoaws:masterfrom
Conversation
…L2 and L3 integration constructs
|
|
|
@peterwoodworth I opted to update a unit test in Not entirely clear on why the build failed, works just fine locally. |
|
Where exactly are you getting that build failure? |
Check the CodeBuild CI Report above, it says "Result: Failed" |
|
Oh duh 🤦 right there. I'm not sure why that happened, no idea why you'd get that error there 🤷 |
peterwoodworth
left a comment
There was a problem hiding this comment.
This looks like it works fine. However we could afford to have more abstraction here, right? Why not allow the user to input the property SecureServerName and then have the CDK handle setting the TlsConfig -> ServerNameToVerify property?
|
We can deal with the build errors once we're ready to approve. Hopefully it won't happen again but if it does we can figure out how to deal with that |
|
Agree! I've updated the MR per your suggestion. Let's see if the build passes this time. |
|
Thank you! It looks good to me, I'll leave it to @nija-at for final review |
packages/@aws-cdk/aws-apigatewayv2-integrations/lib/http/base-types.ts
Outdated
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ig (aws#15469) Adds the option to specify tlsConfig for `AWS::ApiGatewayV2::Integration` resources, to enable use of HTTPS when configuring private integrations. closes aws#14036 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ig (aws#15469) Adds the option to specify tlsConfig for `AWS::ApiGatewayV2::Integration` resources, to enable use of HTTPS when configuring private integrations. closes aws#14036 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds the option to specify tlsConfig for
AWS::ApiGatewayV2::Integrationresources, to enable use of HTTPS when configuring private integrations.closes #14036
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license