Skip to content

chore: add build of experimental modules#15442

Merged
mergify[bot] merged 3 commits intoaws:v2-mainfrom
skinny85:experimental-modules
Jul 10, 2021
Merged

chore: add build of experimental modules#15442
mergify[bot] merged 3 commits intoaws:v2-mainfrom
skinny85:experimental-modules

Conversation

@skinny85
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 commented Jul 7, 2021

This adds a new module that encompasses the build of experimental modules in V2.
It manages a separate Lerna monorepo with version set to independent in preparation for releasing the modules.
The parent module contains the logic of copying the files from the base module,
and changing the values inside (package.json, imports inside TypeScript files, etc.),
so that they depend on aws-cdk-lib.

To be clear, this PR does not release the modules yet; it only makes them part of the build of CDK.

Still to do:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from rix0rrr July 7, 2021 03:26
@skinny85 skinny85 self-assigned this Jul 7, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 7, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 7, 2021
@@ -0,0 +1,230 @@
/**
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear: the code in this file is dogshit.

Reviewers, feel free to rip it apart.

Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩👻

@skinny85 skinny85 added the pr/do-not-merge This PR should not be merged at this time. label Jul 8, 2021
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 8, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from 4f1d8b0 to 88a3a59 Compare July 8, 2021 21:31
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 8, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from 88a3a59 to c30476c Compare July 8, 2021 22:25
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 8, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from c30476c to 850c8d2 Compare July 8, 2021 23:48
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 9, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from 850c8d2 to 527090f Compare July 9, 2021 00:12
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 9, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from 527090f to 2447fc2 Compare July 9, 2021 16:19
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 9, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from 2447fc2 to 356f428 Compare July 9, 2021 22:46
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 9, 2021
@skinny85 skinny85 force-pushed the experimental-modules branch from 356f428 to ff0395a Compare July 9, 2021 23:47
@skinny85 skinny85 force-pushed the experimental-modules branch from ff0395a to 2b54874 Compare July 10, 2021 00:27
@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Jul 10, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7d7d8bb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0d082f1 into aws:v2-main Jul 10, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the experimental-modules branch July 10, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants