fix(iam): PrincipalWithConditions.addCondition does not work#15414
Merged
mergify[bot] merged 6 commits intoaws:masterfrom Jul 19, 2021
Merged
fix(iam): PrincipalWithConditions.addCondition does not work#15414mergify[bot] merged 6 commits intoaws:masterfrom
PrincipalWithConditions.addCondition does not work#15414mergify[bot] merged 6 commits intoaws:masterfrom
Conversation
|
|
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
PrincipalWithConditions.addCondition does not work
rix0rrr
previously approved these changes
Jul 8, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
approved these changes
Jul 19, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
added a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
…5414) In `PrincipalWithConditions` the `conditions` parameter uses the getter syntax to return a new conditions object each time, which means the `addCondition` call will effectively throw away any conditions being added. This PR ensures the conditions added with `addCondition` show up in the resulting principal. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…5414) In `PrincipalWithConditions` the `conditions` parameter uses the getter syntax to return a new conditions object each time, which means the `addCondition` call will effectively throw away any conditions being added. This PR ensures the conditions added with `addCondition` show up in the resulting principal. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
PrincipalWithConditionstheconditionsparameter uses the getter syntax to return a new conditions object each time, which means theaddConditioncall will effectively throw away any conditions being added.This PR ensures the conditions added with
addConditionshow up in the resulting principal.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license