feat(appsync): optional operation parameter for lambdaRequest mapping template#15283
Merged
mergify[bot] merged 5 commits intomasterfrom Jul 19, 2021
Merged
feat(appsync): optional operation parameter for lambdaRequest mapping template#15283mergify[bot] merged 5 commits intomasterfrom
mergify[bot] merged 5 commits intomasterfrom
Conversation
|
|
Contributor
Author
|
@asnaseer-resilient would love to know your thoughts! I have a working integration test that I think is pretty comprehensive but wouldn't mind a second glance |
@BryanPan342 Looks perfect - I can't wait for this to be published. Thanks again for doing this 👍 |
otaviomacedo
approved these changes
Jul 19, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
… template (aws#15283) **[CORE CHANGES]** Add optional `operation` parameter to `lamdaRequest` mapping template. - Defaults to `"Invoke"` - Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function **[MISC]** * Add integration test w/ a verification script to test mapping template * preliminary mapping template unit tests (created an issue to create more testing aws#15274 * Use `path.resolve()` to resolve testing integration test in different directories Fixes: aws#14079 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
… template (aws#15283) **[CORE CHANGES]** Add optional `operation` parameter to `lamdaRequest` mapping template. - Defaults to `"Invoke"` - Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function **[MISC]** * Add integration test w/ a verification script to test mapping template * preliminary mapping template unit tests (created an issue to create more testing aws#15274 * Use `path.resolve()` to resolve testing integration test in different directories Fixes: aws#14079 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CORE CHANGES]
Add optional
operationparameter tolamdaRequestmapping template."Invoke""BatchInvoke"operations directly through the staticlambdaRequestfunction[MISC]
path.resolve()to resolve testing integration test in different directoriesFixes: #14079
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license