feat(aws-elasticloadbalancingv2): Allow listing added listeners on application load balancers#15259
Merged
mergify[bot] merged 8 commits intoaws:masterfrom Jul 7, 2021
Conversation
|
|
peterwoodworth
previously approved these changes
Jul 7, 2021
Contributor
peterwoodworth
left a comment
There was a problem hiding this comment.
This looks good to me, thank you for adding this!
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
peterwoodworth
approved these changes
Jul 7, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…plication load balancers (aws#15259) This PR adds the ability to get access to the list of Listeners that have been added to an Application Load Balancer. This is necessary because when an L3 pattern creates a listener on a load balancer the caller may need to get access to the listener to customize it. I couldn't figure out a great way to make this work for Looked Up or Imported Load Balancers so I decided to throw an error. If there is a better way, let me know and I can change the PR. closes aws#11841 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to get access to the list of Listeners that have been added to an Application Load Balancer. This is necessary because when an L3 pattern creates a listener on a load balancer the caller may need to get access to the listener to customize it.
I couldn't figure out a great way to make this work for Looked Up or Imported Load Balancers so I decided to throw an error. If there is a better way, let me know and I can change the PR.
closes #11841
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license