feat(apigatewayv2): websocket - callback url#15227
Conversation
|
|
2336e82 to
a56a8b3
Compare
nija-at
left a comment
There was a problem hiding this comment.
Nice! Thanks for this contribution. Just a couple of minor comments below.
| readonly api: IWebSocketApi; | ||
|
|
||
| /** | ||
| * The callback URL to this stage. |
There was a problem hiding this comment.
can you describe what a callback url is, and/or link to any available docs?
There was a problem hiding this comment.
done
The most appropriate document might be https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-basic-concept.html
but some people can't understand it with just this URL, so I added the URL explaining how to use it, https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-how-to-call-websocket-api-connections.html
| expect(() => {imported.url;}).toThrow(); | ||
| expect(() => {imported.callbackUrl;}).toThrow(); |
There was a problem hiding this comment.
| expect(() => {imported.url;}).toThrow(); | |
| expect(() => {imported.callbackUrl;}).toThrow(); | |
| expect(() => imported.url).toThrow(); | |
| expect(() => imported.callbackUrl).toThrow(); |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I added property to extract websocket callback endpoint url to WebSocketStage. I added it simply like existing `url` property. It's my first time to submit PR. Please point out any mistakes. closes aws#14836 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@bitoku I just noticed there's a typo in the documentation here. But the second line should read |
|
@adam-nielsen oops, sorry |
This PR fix typo in README of `aws-apigatewayv2`. I made PR #15227 and was pointed out typo. According to the PR, `webSocketStage` is correct. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I added property to extract websocket callback endpoint url to WebSocketStage. I added it simply like existing `url` property. It's my first time to submit PR. Please point out any mistakes. closes aws#14836 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR fix typo in README of `aws-apigatewayv2`. I made PR aws#15227 and was pointed out typo. According to the PR, `webSocketStage` is correct. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR fix typo in README of `aws-apigatewayv2`. I made PR aws#15227 and was pointed out typo. According to the PR, `webSocketStage` is correct. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I added property to extract websocket callback endpoint url to WebSocketStage.
I added it simply like existing
urlproperty.It's my first time to submit PR.
Please point out any mistakes.
closes #14836
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license