feat(s3): notifications to existing buckets#15158
Merged
mergify[bot] merged 178 commits intoaws:masterfrom Jun 16, 2021
Merged
Conversation
added 30 commits
November 29, 2020 05:11
Initial custom resource changes to support adding notifications to an existing S3 bucket TODO: Move up the addNotification functions to BucketBase
When removing elements from the existing configuration we should also check to remove the old configuration
Move `addEventNotification` to BucketBase to support setting up bucket notification on existing buckets
…ael),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),131(lxd),132(sambashare),135(docker) and clarify code
Currently using semi quotes trancates the documentation
Currently using semi quotes trancates the documentation
…sting-s3-bucket chore: migrate to an ID based implementation and split managed and unmanaged bucket handling
…sting-s3-bucket
…sting-s3-bucket chore: revert change to lambda event source
|
|
Contributor
Author
|
Sorry @iliapolo i had to move it to my personal github account |
iliapolo
approved these changes
Jun 16, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
matthewsvu
pushed a commit
to matthewsvu/aws-cdk
that referenced
this pull request
Jun 22, 2021
An update custom resource changes to support adding notifications to an existing S3 bucket Resolves aws#2004 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
An update custom resource changes to support adding notifications to an existing S3 bucket Resolves aws#2004 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update custom resource changes to support adding notifications to an existing S3 bucket
Resolves #2004
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license