chore: permissions for github actions#14767
Merged
Conversation
Separated the 'upgrade' step and the 'pull request' step into separate jobs to build a better security boundary between the two. The latter requies write permission on the repo to create a pull request.
|
|
Contributor
Author
TestingRan the workflow on my private fork to provide that it works - https://github.com/nija-at/aws-cdk/actions/runs/856551188. |
iliapolo
reviewed
May 19, 2021
otaviomacedo
approved these changes
May 19, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
By default, all Github actions have read permissions via the standard `GITHUB_TOKEN`. For jobs that require write permission, explicitly add the necessary permissions. In the case of the 'Yarn Upgrade' Github action, separated the 'upgrade' step and the 'pull request' step into separate jobs to build a better security boundary between the two. Inspired from: https://github.com/projen/projen/blob/a4f875d07b57f8f8247b9352e34c3c83759afe82/.github/workflows/upgrade-dependencies.yml
dankmemes2020
added a commit
to dankmemes2020/aws-cdk
that referenced
this pull request
Sep 21, 2021
Action permissions were restricted in aws#14767 but this broke the stale issue handling action. This opens read permissions and write permissions to PRs for this action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, all Github actions have read permissions via the standard
GITHUB_TOKEN. For jobs that require write permission, explicitlyadd the necessary permissions.
In the case of the 'Yarn Upgrade' Github action, separated the
'upgrade' step and the 'pull request' step into separate
jobs to build a better security boundary between the two.
Inspired from: https://github.com/projen/projen/blob/a4f875d07b57f8f8247b9352e34c3c83759afe82/.github/workflows/upgrade-dependencies.yml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license