feat(eks): imported kubectl provider for imported clusters#14689
feat(eks): imported kubectl provider for imported clusters#14689mergify[bot] merged 56 commits intoaws:masterfrom
Conversation
|
|
|
so user will be able to call const provider = KubectlProvider.fromKubectlProviderAttributes(...)
const cluster = Cluster.fromClusterAttributes(..., { kubectlprovider: provider })and then any call of cluster.addServiceAccount();will trigger existing kubectl provider |
|
@aka-toxa Sorry for the delay. I like this approach. You still up to follow it through? |
|
hi guys |
Pull request has been modified.
0e5b9d8 to
15b6c94
Compare
15b6c94 to
aa3bbc0
Compare
|
hey @iliapolo it looks like I have all tests and docs now can you review this again please? |
|
@aka-toxa can you please ask for a new review from iliapolo, I can't and don't have enough permissions. |
|
@markussiebert asked. thanks for your contribution! I appreciate this |
|
@iliapolo can you please take a look at this? |
Pull request has been modified.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This resolves [issue#12107](aws#12107) we bring the ability to provide existing kubectl provider to the imported cluster so we can create k8s kubectl role and tight it's trusted entity to single lambda and pass this single lambda to all cdk stacks that works with imported clusters @iliapolo can you please take a look on this if this approach is fine? if it is I will add documentation and tests ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This resolves issue#12107
we bring the ability to provide existing kubectl provider to the imported cluster
so we can create k8s kubectl role and tight it's trusted entity to single lambda and pass this single lambda to all cdk stacks that works with imported clusters
@iliapolo can you please take a look on this if this approach is fine? if it is I will add documentation and tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license