feat(ecs): Adding support for ECS Exec#14670
Conversation
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
…arekh/support-for-enable-exec-command
…thub.com/upparekh/aws-cdk into upparekh/support-for-enable-exec-command
iamhopaul123
left a comment
There was a problem hiding this comment.
This is so good! Can't believe this is happening!
SoManyHs
left a comment
There was a problem hiding this comment.
This is so great! Just a few small nits for things like wording and style, but otherwise LGTM!! 🎉
Co-authored-by: Hsing-Hui Hsu <hsinghui@amazon.com>
iamhopaul123
left a comment
There was a problem hiding this comment.
This is awesome! You might want to manually test its main functionalities and address Hsinghui's feedback before merging the PR. But other than those I'll ship it 🚢
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes aws#13618 This PR adds support for ECS exec command. It adds necessary IAM permissions for the AWS Systems Manager (SSM) to enable exec and also adds IAM permissions for allowing the exec command result logs to be routed to either CloudWatch logs/ S3 Bucket or both. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes #13618
This PR adds support for ECS exec command. It adds necessary IAM permissions for the AWS Systems Manager (SSM) to enable exec and also adds IAM permissions for allowing the exec command result logs to be routed to either CloudWatch logs/ S3 Bucket or both.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license