feat(appsync): elasticsearch data source for graphql api#14651
Merged
mergify[bot] merged 3 commits intoaws:masterfrom May 13, 2021
Merged
feat(appsync): elasticsearch data source for graphql api#14651mergify[bot] merged 3 commits intoaws:masterfrom
mergify[bot] merged 3 commits intoaws:masterfrom
Conversation
|
|
2 tasks
MrArnoldPalmer
previously requested changes
May 12, 2021
Contributor
MrArnoldPalmer
left a comment
There was a problem hiding this comment.
one question and a nit for the unit test name.
packages/@aws-cdk/aws-appsync/test/appsync-elasticsearch.test.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
MrArnoldPalmer
approved these changes
May 13, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Implement support for elasticsearch data source. Endpoint is fixed to `https` URL as through testing, CloudFormations requires the domain to be in the form of `https://[...]`. Fixes aws#6063 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for elasticsearch data source.
Endpoint is fixed to
httpsURL as through testing, CloudFormations requires the domain to be in the form ofhttps://[...].Fixes #6063
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license