fix(apigatewayv2): incorrect metric names for client and server-side errors#14541
Merged
mergify[bot] merged 1 commit intomasterfrom May 5, 2021
Merged
fix(apigatewayv2): incorrect metric names for client and server-side errors#14541mergify[bot] merged 1 commit intomasterfrom
mergify[bot] merged 1 commit intomasterfrom
Conversation
|
|
…errors In the HTTP API offering of API Gateway, the [metric names][1] for client-side and server-side errors are '4xx' and '5xx'. This was incorrectly configured as '4XXError' and '5XXError' which is the [metric name in the REST API offering][2]. fixes #14503 In addition, a previous change elevated metrics defined in HTTP API such that it is also available for the Websocket API offering. Unfortunately, the set of metrics or metric names available in the [HTTP API][1] and [Websocket API][3] offerings do not match up. Hence, remove these metric names from Websocket APIs. [1]: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-metrics.html [2]: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-metrics-and-dimensions.html [3]: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-logging.html BREAKING CHANGES: The `metricXXX` methods are no longer available in the `IApi` interface. The existing ones are moved into `IHttpApi` and new ones will be added to `IWebsocketApi`. * **apigatewayv2:** The `metricXXX` methods are no longer available in the `IStage` interface. The existing ones are moved into `IHttpStage` and new ones will be added to the `IWebsocketStage`.
2aed299 to
44b6562
Compare
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
approved these changes
May 5, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…errors (aws#14541) In the HTTP API offering of API Gateway, the [metric names][1] for client-side and server-side errors are '4xx' and '5xx'. This was incorrectly configured as '4XXError' and '5XXError' which is the [metric name in the REST API offering][2]. fixes aws#14503 In addition, a previous change elevated metrics defined in HTTP API such that it is also available for the Websocket API offering. Unfortunately, the set of metrics or metric names available in the [HTTP API][1] and [Websocket API][3] offerings do not match up. Hence, remove these metric names from Websocket APIs. [1]: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-metrics.html [2]: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-metrics-and-dimensions.html [3]: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-logging.html BREAKING CHANGE: The `metricXXX` methods are no longer available in the `IApi` interface. The existing ones are moved into `IHttpApi` and new ones will be added to `IWebsocketApi`. * **apigatewayv2:** The `metricXXX` methods are no longer available in the `IStage` interface. The existing ones are moved into `IHttpStage` and new ones will be added to the `IWebsocketStage`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…errors (aws#14541) In the HTTP API offering of API Gateway, the [metric names][1] for client-side and server-side errors are '4xx' and '5xx'. This was incorrectly configured as '4XXError' and '5XXError' which is the [metric name in the REST API offering][2]. fixes aws#14503 In addition, a previous change elevated metrics defined in HTTP API such that it is also available for the Websocket API offering. Unfortunately, the set of metrics or metric names available in the [HTTP API][1] and [Websocket API][3] offerings do not match up. Hence, remove these metric names from Websocket APIs. [1]: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-metrics.html [2]: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-metrics-and-dimensions.html [3]: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-logging.html BREAKING CHANGE: The `metricXXX` methods are no longer available in the `IApi` interface. The existing ones are moved into `IHttpApi` and new ones will be added to `IWebsocketApi`. * **apigatewayv2:** The `metricXXX` methods are no longer available in the `IStage` interface. The existing ones are moved into `IHttpStage` and new ones will be added to the `IWebsocketStage`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HTTP API offering of API Gateway, the metric names for
client-side and server-side errors are '4xx' and '5xx'.
This was incorrectly configured as '4XXError' and '5XXError' which is
the metric name in the REST API offering.
fixes #14503
In addition, a previous change elevated metrics defined in HTTP API such
that it is also available for the Websocket API offering. Unfortunately,
the set of metrics or metric names available in the HTTP API and
Websocket API offerings do not match up.
Hence, remove these metric names from Websocket APIs.
BREAKING CHANGE: The
metricXXXmethods are no longer available in theIApiinterface. The existing ones are moved intoIHttpApiand newones will be added to
IWebsocketApi.metricXXXmethods are no longer available inthe
IStageinterface. The existing ones are moved intoIHttpStageand new ones will be added to the
IWebsocketStage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license