chore: add validation for ubergen aws-cdk-lib README import re-writes#14302
Merged
mergify[bot] merged 2 commits intomasterfrom Apr 22, 2021
Merged
chore: add validation for ubergen aws-cdk-lib README import re-writes#14302mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
|
|
Contributor
Author
|
Odd... In the CodeBuild PR build, the readme properties are completely missing in the jsii assembly file. This is what's causing the build to fail. Pushing incremental changes with more and more logging to try to determine why that is... |
Imports in READMEs are now rewritten from '@aws-cdk/...' to 'aws-cdk-lib'. This change was introduced in #14255, but no validation was included in the original PR. This change introduces a post-build validation step for aws-cdk-lib to ensure that the module rewrites were properly done.
c7b4bdc to
aa34b17
Compare
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…aws#14302) Imports in READMEs are now rewritten from '@aws-cdk/...' to 'aws-cdk-lib'. This change was introduced in aws#14255, but no validation was included in the original PR. This change introduces a post-build validation step for aws-cdk-lib to ensure that the module rewrites were properly done. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…aws#14302) Imports in READMEs are now rewritten from '@aws-cdk/...' to 'aws-cdk-lib'. This change was introduced in aws#14255, but no validation was included in the original PR. This change introduces a post-build validation step for aws-cdk-lib to ensure that the module rewrites were properly done. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports in READMEs are now rewritten from '@aws-cdk/...' to 'aws-cdk-lib'.
This change was introduced in #14255, but no validation was included in the
original PR. This change introduces a post-build validation step for aws-cdk-lib
to ensure that the module rewrites were properly done.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license