feat(aws-ecs): Expose logdriver "mode" property#13965
feat(aws-ecs): Expose logdriver "mode" property#13965mergify[bot] merged 9 commits intoaws:masterfrom
Conversation
|
|
|
@SoManyHs Can you please review this when you get a chance? |
|
|
bvtujo
left a comment
There was a problem hiding this comment.
Thank you so much for adding this property. I have just a small syntax suggestion to make the property definition in bind more congruent with the others, but other than that this looks good to me!
Co-authored-by: Austin Ely <austiely@amazon.com>
bvtujo
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the quick turnaround!
|
@bvtujo Could you please re-approve? |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #13845
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license