Skip to content

feat(docdb): Support multiple security groups to DatabaseCluster#13290

Merged
mergify[bot] merged 5 commits intoaws:masterfrom
jericht:jericht/docdb_add_security_group
May 5, 2021
Merged

feat(docdb): Support multiple security groups to DatabaseCluster#13290
mergify[bot] merged 5 commits intoaws:masterfrom
jericht:jericht/docdb_add_security_group

Conversation

@jericht
Copy link
Contributor

@jericht jericht commented Feb 25, 2021 •
edited by iliapolo
Loading

Resolves #13294

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 25, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Feb 25, 2021
@jericht jericht force-pushed the jericht/docdb_add_security_group branch from 2464b85 to 5b33c00 Compare February 25, 2021 22:07
This was referenced Feb 25, 2021
Merged
Closed
@jericht jericht marked this pull request as ready for review February 26, 2021 15:48
@iliapolo iliapolo changed the title feat(aws-docdb): add ability to add security groups to DatabaseCluster feat(docdb): Support multiple security groups to DatabaseCluster Mar 20, 2021
@jericht jericht force-pushed the jericht/docdb_add_security_group branch from f151268 to 099d595 Compare May 3, 2021 22:00
@gitpod-io
Copy link

gitpod-io bot commented May 3, 2021

@jericht jericht force-pushed the jericht/docdb_add_security_group branch from 099d595 to a446b4f Compare May 3, 2021 22:04
iliapolo
iliapolo reviewed May 4, 2021
View reviewed changes
iliapolo
iliapolo reviewed May 4, 2021
View reviewed changes
iliapolo
iliapolo previously approved these changes May 4, 2021
View reviewed changes
@mergify mergify bot dismissed iliapolo’s stale review May 4, 2021 17:54

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented May 5, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b66b10a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1a97b66 into aws:master May 5, 2021
@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
@jericht @john-tipper
feat(docdb): Support multiple security groups to DatabaseCluster (aws…
dbcd7fa 
…#13290)

Resolves aws#13294

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@jericht @hollanddd
feat(docdb): Support multiple security groups to DatabaseCluster (aws…
53d7393 
…#13290)

Resolves aws#13294

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels

@aws-cdk/aws-docdb Related to Amazon DocumentDB

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(docdb): Multiple security groups for DatabaseCluster

3 participants

@jericht @aws-cdk-automation @iliapolo