fix(ec2): volume props validations are incorrect#12821
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Feb 9, 2021
Merged
fix(ec2): volume props validations are incorrect#12821mergify[bot] merged 3 commits intoaws:masterfrom
mergify[bot] merged 3 commits intoaws:masterfrom
Conversation
|
|
rix0rrr
previously approved these changes
Feb 9, 2021
Contributor
rix0rrr
left a comment
There was a problem hiding this comment.
My kingdom for someone who can factor this code better, but thanks for the factual fixes!
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
approved these changes
Feb 9, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TLadd
pushed a commit
to TLadd/aws-cdk
that referenced
this pull request
Feb 9, 2021
Fixes aws#12816. * add validation: must specify `iops` if `volumeType` is `io1` or `io2` * fix validation: `iops` may only be specified if the `volumeType` is `io1`, `io2` or `gp3` * fix validation: `iops` minimum & maximum for `io1`, `io2` and `gp3` respectively * fix validation: `iops` maximum ratio (IOPS/Gib) for `io1`, `io2` and `gp3` respectively * fix validation: `multi-attach` is supported exclusively on `io1` and `io2` volumes. * fix validation: `size` minimum & maximum for all `volumeType` (including `gp3` and `io2` which was a bug specified in aws#12816) Unit tests are either added / fixed for above changes. References: aws#12074 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
Fixes aws#12816. * add validation: must specify `iops` if `volumeType` is `io1` or `io2` * fix validation: `iops` may only be specified if the `volumeType` is `io1`, `io2` or `gp3` * fix validation: `iops` minimum & maximum for `io1`, `io2` and `gp3` respectively * fix validation: `iops` maximum ratio (IOPS/Gib) for `io1`, `io2` and `gp3` respectively * fix validation: `multi-attach` is supported exclusively on `io1` and `io2` volumes. * fix validation: `size` minimum & maximum for all `volumeType` (including `gp3` and `io2` which was a bug specified in aws#12816) Unit tests are either added / fixed for above changes. References: aws#12074 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12816.
iopsifvolumeTypeisio1orio2iopsmay only be specified if thevolumeTypeisio1,io2orgp3iopsminimum & maximum forio1,io2andgp3respectivelyiopsmaximum ratio (IOPS/Gib) forio1,io2andgp3respectivelymulti-attachis supported exclusively onio1andio2volumes.sizeminimum & maximum for allvolumeType(includinggp3andio2which was a bug specified in (@aws-cdk/aws-ec2): Stack verification failed for newer EBS volumeType #12816)Unit tests are either added / fixed for above changes.
References:
#12074
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license