feat(kinesis): Basic stream level metrics#12556
feat(kinesis): Basic stream level metrics#12556mergify[bot] merged 5 commits intoaws:masterfrom lgvo:stream-metrics
Conversation
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
|
@lgvo Thanks for this! apologies its taking a while to review. I have it in my queue 👍 |
iliapolo
left a comment
There was a problem hiding this comment.
Looks good. But please add documentation sources to all non canned metrics that you exposed.
| You can use common metrics from your stream to create alarms and/or dashboards. | ||
| Read more about Kinesis metrics at [Creating and Managing Streams](https://docs.aws.amazon.com/streams/latest/dev/working-with-streams.html) | ||
|
|
||
| You can find bellow a example of building a dashboard with the default metrics. |
There was a problem hiding this comment.
No need, it's a little overwhelming to look at. We don't need to explain how to create dashboards, we just need to mention that metrics are available using stream.metricXXX methods and show an example or two.
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
|
@lgvo Are still keeping track of this PR? |
|
@iliapolo Yes, just too busy with work right now. I'm working on some changes |
|
Cool. Keeping this open then 👍 |
|
I added Changed the README as well. |
|
@iliapolo please feel free to ping me on slack, if you have any questions. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes aws#12555 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes aws#12555 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #12555
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license