fix(events): cannot have more than one cross-account Rule #12538
Closed
mazayan wants to merge 2 commits intoaws:masterfrom
Closed
fix(events): cannot have more than one cross-account Rule #12538mazayan wants to merge 2 commits intoaws:masterfrom
mazayan wants to merge 2 commits intoaws:masterfrom
Conversation
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Assigned @rix0rrr , who now owns the |
rix0rrr
requested changes
Jan 26, 2021
| new CfnEventBusPolicy(eventBusPolicyStack, 'GivePermToOtherAccount', { | ||
| action: 'events:PutEvents', | ||
| statementId: `Allow-account-${sourceAccount}`, | ||
| statementId: `Allow-account-${sourceAccount}-${Names.uniqueId(this)}`, |
Contributor
There was a problem hiding this comment.
What is the maximum length of a Sid? Can you ensure this length never grows too large?
Contributor
There was a problem hiding this comment.
this.node.addr may be better.
924c117 to
ebfd5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12479
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Note: this pull request is in reference to git issue: #12479