feat(stepfunctions-tasks): EcsRunTask now uses taskDefinition family instead of ARN#12436
feat(stepfunctions-tasks): EcsRunTask now uses taskDefinition family instead of ARN#12436mergify[bot] merged 6 commits intoaws:masterfrom ayush987goyal:pr/sfn-fargate
Conversation
|
|
|
@shivlaks Mind taking a quick look at this? Do you think we should go for a better name for the prop? |
Pull request has been modified.
|
Hi @shivlaks , quick reminder for this :) |
There was a problem hiding this comment.
@ayush987goyal looks good, couple minor comments. Please update the commit description to include the implementation approach taken as it currently only contains a couple of reference links.
would also love if @MrArnoldPalmer in case my understanding of the task definition arn is missing anything
|
@shivlaks this LGTM. It definitely makes sense to drop the revision here and using family seems like the best way to do it. 👍🏻 |
|
|
Pull request has been modified.
|
@shivlaks Updated the description and addressed the review comments. |
shivlaks
left a comment
There was a problem hiding this comment.
@ayush987goyal looks great! thanks for the contribution!!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…instead of ARN (aws#12436) feat(stepfunctions-tasks): EcsRunTask now uses taskDefinition family instead of ARN Currently the ECS run task implementation uses full ARN of the task definition. This ARN contains the ACTIVE revision at the end. The ACTIVE revision keeps on changing as the task definition changes causing potential failures (refer the issue). This change now lets the run task API to use task definition family (and corresponding ARN which does not contain the revision) to run the task. Using the family would mean that the latest ACTIVE revision of task-definition is used always. This is supported out of the box by ECS (refer the below refs). Parameter Ref: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html#ECS-RunTask-request-taskDefinition Permissions Ref: https://docs.aws.amazon.com/step-functions/latest/dg/ecs-iam.html closes aws#12080 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
feat(stepfunctions-tasks): EcsRunTask now uses taskDefinition family instead of ARN
Currently the ECS run task implementation uses full ARN of the task definition. This ARN contains the ACTIVE revision at the end. The ACTIVE revision keeps on changing as the task definition changes causing potential failures (refer the issue).
This change now lets the run task API to use task definition family (and corresponding ARN which does not contain the revision) to run the task. Using the family would mean that the latest ACTIVE revision of task-definition is used always. This is supported out of the box by ECS (refer the below refs).
Parameter Ref: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html#ECS-RunTask-request-taskDefinition
Permissions Ref: https://docs.aws.amazon.com/step-functions/latest/dg/ecs-iam.html
closes #12080
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license