feat(apigateway): configure integration options on LambdaRestApi#12004
Closed
yamatatsu wants to merge 9 commits intoaws:masterfrom
Closed
feat(apigateway): configure integration options on LambdaRestApi#12004yamatatsu wants to merge 9 commits intoaws:masterfrom
yamatatsu wants to merge 9 commits intoaws:masterfrom
Conversation
|
|
nija-at
previously requested changes
Jan 6, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR. Please see some of my comments below.
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Contributor
Author
|
Thanks for your comments, nija-at. |
nija-at
previously approved these changes
Jan 7, 2021
nija-at
previously requested changes
Jan 7, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
Looks like there's a failing test. Can you look at the build output. A link to the build logs are in the automated comment above.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
suggested changes
Feb 15, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
Could you address the failing build?
Contributor
|
Closing this old pull request. Please open a new pull request when you have updates. |
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
This adds an `integrationOptions` field to the `LambdaRestApiProps` and ensures that `proxy` cannot be set differently from the base `proxy` flag (but discourages setting it at all). This will allow setting the `cacheKeyParameters`, `allowTestInvoke`, and `vpcLink` configuration fields without having to fall back to using a regular `RestApi`. Some of this is inspired by #12004 and its review comments, which was closed earlier this year due to inactivity. Resolves: #3269 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…17065) This adds an `integrationOptions` field to the `LambdaRestApiProps` and ensures that `proxy` cannot be set differently from the base `proxy` flag (but discourages setting it at all). This will allow setting the `cacheKeyParameters`, `allowTestInvoke`, and `vpcLink` configuration fields without having to fall back to using a regular `RestApi`. Some of this is inspired by aws#12004 and its review comments, which was closed earlier this year due to inactivity. Resolves: aws#3269 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3269
But I wonder that why #3269 was removed label "good first issue".
I guess there are some plans to resolve this issue without fix as this PR?
Assuming that, I'm sorry that I try to fix this issue without your consultation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license