fix(ecs): remove Fargate environment files restriction#11820
Merged
SoManyHs merged 6 commits intoaws:masterfrom Dec 10, 2020
Merged
fix(ecs): remove Fargate environment files restriction#11820SoManyHs merged 6 commits intoaws:masterfrom
SoManyHs merged 6 commits intoaws:masterfrom
Conversation
|
|
piradeepk
reviewed
Dec 2, 2020
Contributor
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Contributor
Author
|
Don't auto-close. |
Contributor
Author
|
@piradeepk @eladb your review would be appreciated! |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SoManyHs
approved these changes
Dec 10, 2020
Contributor
SoManyHs
left a comment
There was a problem hiding this comment.
Awesome! Thank you for adding the test -- really appreciate your contribution! <3
This was referenced Sep 9, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2023
…gate (#27081) Currently, CDK document includes the following description. https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs-readme.html#environment-variables > Support for environment files is restricted to the EC2 launch type for files hosted on S3. However, this is out of date. Fargate has been [supported environment files](https://aws.amazon.com/jp/blogs/containers/latest-updates-to-aws-fargate-for-amazon-ecs/), and this restriction on CDK had been already removed by #11820. This PR removes the out of date description from document. Closes #18226 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mikewrighton
pushed a commit
that referenced
this pull request
Sep 14, 2023
…gate (#27081) Currently, CDK document includes the following description. https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs-readme.html#environment-variables > Support for environment files is restricted to the EC2 launch type for files hosted on S3. However, this is out of date. Fargate has been [supported environment files](https://aws.amazon.com/jp/blogs/containers/latest-updates-to-aws-fargate-for-amazon-ecs/), and this restriction on CDK had been already removed by #11820. This PR removes the out of date description from document. Closes #18226 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is limitation no longer exists of earlier in Nov (see https://aws.amazon.com/about-aws/whats-new/2020/11/aws-fargate-for-amazon-ecs-launches-features-focused-on-configuration-and-metrics/)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license