Move project() call to CMakeLists.txt#1909
Merged
blueyed merged 1 commit intoawesomeWM:masterfrom Jul 9, 2017
Merged
Conversation
CMake "fakes" a call to "project(Project C CXX)" if it does not see a project() call in CMakeLists.txt. Since we had this call in a different file, this default applied. This meant that CMake unnecessarily required a C++ compiler. Fix/work-around this by moving the call to project() into CMakeLists.txt Reference: awesomeWM#1907 (comment) Signed-off-by: Uli Schlachter <psychon@znc.in>
Codecov Report
@@ Coverage Diff @@
## master #1909 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 397 397
Lines 27123 27123
Branches 983 983
=======================================
Hits 21821 21821
Misses 5298 5298
Partials 4 4
Continue to review full report at Codecov.
|
Member
|
Yes, it helps. |
Member
|
Also required for the example tests. |
Member
Author
|
You mean " |
petoju
pushed a commit
to petoju/awesome
that referenced
this pull request
Sep 10, 2017
CMake "fakes" a call to "project(Project C CXX)" if it does not see a project() call in CMakeLists.txt. Since we had this call in a different file, this default applied. This meant that CMake unnecessarily required a C++ compiler. Fix/work-around this by moving the call to project() into CMakeLists.txt Reference: awesomeWM#1907 (comment) Signed-off-by: Uli Schlachter <psychon@znc.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake "fakes" a call to "project(Project C CXX)" if it does not see a
project() call in CMakeLists.txt. Since we had this call in a different
file, this default applied. This meant that CMake unnecessarily required
a C++ compiler.
Fix/work-around this by moving the call to project() into CMakeLists.txt
Reference: #1907 (comment)
Signed-off-by: Uli Schlachter psychon@znc.in
@blueyed This should allow you to get rid of the C++ compiler in your docker build.