Skip to content

Add -tickon parameter in !i effect to support tick_on_combatant_id#2217

Merged
codybanman merged 2 commits intoavrae:nightlyfrom
justhalf:fr/effect-tickon
Oct 28, 2025
Merged

Add -tickon parameter in !i effect to support tick_on_combatant_id#2217
codybanman merged 2 commits intoavrae:nightlyfrom
justhalf:fr/effect-tickon

Conversation

@justhalf
Copy link
Copy Markdown
Contributor

Summary

Even though InitiativeEffect has the tick_on_combatant_id argument to specify when an effect timer would tick (as seen in https://github.com/avrae/avrae/blob/nightly/cogs5e/initiative/effects/effect.py#L99), it is not yet included as one of the parameters in !i effect command.

This PR adds the -tickon <combatant> additional argument to !i effect to support that use case.

Changelog Entry

Add -tickon <combatant> argument to !i effect

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.

@codybanman codybanman merged commit 097a7e9 into avrae:nightly Oct 28, 2025
7he4lph4 pushed a commit to 7he4lph4/avrae that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants