fix: skip nil rerun parameters#46
Merged
avivsinai merged 1 commit intoavivsinai:mainfrom Apr 7, 2026
Merged
Conversation
Avoid serializing missing rerun parameter values into the literal string "<nil>". This keeps rerun payloads compatible with Jenkins jobs that define optional run parameters. Made-with: Cursor
Owner
|
@dependabot rebase |
avivsinai
approved these changes
Apr 7, 2026
Owner
avivsinai
left a comment
There was a problem hiding this comment.
LGTM — nil check is in the right place, tests are solid. All CI green (lint, unit, e2e). Minor follow-ups (zero-value regression test, nil display in human output) tracked separately.
avivsinai
added a commit
that referenced
this pull request
Apr 7, 2026
Add displayParameterValue() to format nil params as "" instead of "<nil>" in run view output. The rerun path (collectRerunParameters) already skips nil values via #46; this fixes the display path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
avivsinai
added a commit
that referenced
this pull request
Apr 7, 2026
Prove that empty string, zero int, and false bool values survive the nil filter introduced in #46, while nil is still excluded. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
avivsinai
added a commit
that referenced
this pull request
Apr 7, 2026
* fix: render nil parameter values as empty string in human output Add displayParameterValue() to format nil params as "" instead of "<nil>" in run view output. The rerun path (collectRerunParameters) already skips nil values via #46; this fixes the display path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: add zero-value regression test for collectRerunParameters Prove that empty string, zero int, and false bool values survive the nil filter introduced in #46, while nil is still excluded. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid serializing missing rerun parameter values into the literal string "". This keeps rerun payloads compatible with Jenkins jobs that define optional run parameters.